Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(go): use functional options pattern #3306

Merged
merged 6 commits into from
Jul 16, 2024
Merged

fix(go): use functional options pattern #3306

merged 6 commits into from
Jul 16, 2024

Conversation

millotp
Copy link
Collaborator

@millotp millotp commented Jul 3, 2024

🧭 What and Why

Use the functional pattern for options which is easier to work with and more widely spread (example).

@millotp millotp self-assigned this Jul 3, 2024
@algolia-bot
Copy link
Collaborator

algolia-bot commented Jul 15, 2024

✔️ Code generated!

Name Link
🪓 Triggered by 7afe0d90c039bcf1f26b77a0aad34111cd1e589b
🍃 Generated commit e59632333887bce0072228f9f984c2c6fcef1681
🌲 Generated branch generated/fix/go-opts

@algolia algolia deleted a comment from github-actions bot Jul 15, 2024
@millotp millotp marked this pull request as ready for review July 15, 2024 14:56
@millotp millotp requested a review from a team as a code owner July 15, 2024 14:56
@millotp millotp requested review from Fluf22 and shortcuts July 15, 2024 14:56
Copy link

github-actions bot commented Jul 15, 2024

Copy link
Member

@shortcuts shortcuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wonderful, usage is much better

@millotp millotp merged commit e3d766a into main Jul 16, 2024
20 checks passed
@millotp millotp deleted the fix/go-opts branch July 16, 2024 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants