Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dart): use qs_dart for HTTP query encoding in DioRequester #3294

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

techouse
Copy link

@techouse techouse commented Jul 1, 2024

馃Л What and Why

Use qs_dart to encode the HTTP query in DioRequester.

Why? I think that using a naive approach like

"${uri.toString()}?${request.queryParameters.entries.map((e) => "${e.key}=${e.value}").join("&")}");

is not exhaustive enough.

Changes included:

  • change DioRequester.requestUri method

Full disclosure: I am the author of qs_dart which is itself is a port of qs.
qs_dart has extensive tests and has been used in Chopper since v7.4.0.

@techouse techouse requested a review from a team as a code owner July 1, 2024 08:37
@techouse techouse requested review from Fluf22 and shortcuts July 1, 2024 08:37
@techouse techouse changed the title feat(dart): use qs_dart for HTTP query encoding feat(dart): use qs_dart for HTTP query encoding in DioRequester Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant