Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): use docker #2525

Draft
wants to merge 33 commits into
base: main
Choose a base branch
from
Draft

chore(ci): use docker #2525

wants to merge 33 commits into from

Conversation

millotp
Copy link
Collaborator

@millotp millotp commented Jan 12, 2024

🧭 What and Why

Instead of initizalizing everything locally and on the CI, we can reuse the same docker image to save a lot of time.

@millotp millotp self-assigned this Jan 12, 2024
@millotp millotp requested a review from a team as a code owner January 12, 2024 10:54
Copy link

netlify bot commented Jan 12, 2024

Deploy Preview for api-clients-automation ready!

Name Link
🔨 Latest commit 9a972f8
🔍 Latest deploy log https://app.netlify.com/sites/api-clients-automation/deploys/65b2288f8ce3d60008b1791a
😎 Deploy Preview https://deploy-preview-2525--api-clients-automation.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

shortcuts
shortcuts previously approved these changes Jan 12, 2024
Copy link
Member

@shortcuts shortcuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I LOVE IT GG

@algolia-bot
Copy link
Collaborator

algolia-bot commented Jan 12, 2024

🔨 The codegen job will run at the end of the CI.

Make sure your last commit does not contain generated code, it will be automatically pushed by our CI.

@millotp
Copy link
Collaborator Author

millotp commented Jan 12, 2024

this doesn't seem to be faster, I think we need to shrink the image size a lot

@shortcuts
Copy link
Member

this doesn't seem to be faster, I think we need to shrink the image size a lot

If fine with it not being faster personally as long as it reduces the friction between local/CI it's still a huge improvement

@morganleroi
Copy link
Contributor

Wooo this is indeed a big improvment if it does not kills the CI duration !

@millotp millotp marked this pull request as draft January 15, 2024 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants