Fix race with interfaces going up. #16
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
From https://www.freedesktop.org/wiki/Software/systemd/NetworkTarget/ network-pre.target is a target that may be used to order services before any network interface is configured. Its primary purpose is for usage with firewall services that want to establish a firewall before any network interface is up. It's a passive unit: you cannot start it directly and it is not pulled in by the the network management service, but by the service that wants to run before it. Network management services hence should set After=network-pre.target, but avoid any Wants=network-pre.target or even Requires=network-pre.target. Services that want to be run before the network is configured should place Before=network-pre.target and also set Wants=network-pre.target to pull it in. This way, unless there's actually a service that needs to be ordered before the network is up the target is not pulled in, hence avoiding any unnecessary synchronization point.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From https://www.freedesktop.org/wiki/Software/systemd/NetworkTarget/
network-pre.target is a target that may be used to order services
before any network interface is configured. Its primary purpose is for
usage with firewall services that want to establish a firewall before
any network interface is up. It's a passive unit: you cannot start it
directly and it is not pulled in by the the network management service,
but by the service that wants to run before it. Network management
services hence should set After=network-pre.target, but avoid any
Wants=network-pre.target or even Requires=network-pre.target. Services
that want to be run before the network is configured should place
Before=network-pre.target and also set Wants=network-pre.target to pull
it in. This way, unless there's actually a service that needs to be
ordered before the network is up the target is not pulled in, hence
avoiding any unnecessary synchronization point.