-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Persisting appointment price & allowing custom price entry #1479
Open
stevenkissack
wants to merge
11
commits into
alextselegidis:develop
Choose a base branch
from
stevenkissack:feat/appointment-charged-amount
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Feature: Persisting appointment price & allowing custom price entry #1479
stevenkissack
wants to merge
11
commits into
alextselegidis:develop
from
stevenkissack:feat/appointment-charged-amount
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@alextselegidis tagging you as I see it didn't auto assign or request review, so not sure if you got a notification 👍 |
I've now deployed this on my development installation and worked fine, I will wait until you've reviewed before running on production. |
tm8544
added a commit
to tm8544/easyappointments
that referenced
this pull request
Mar 30, 2024
…ezone_to_setting.php Renamed file to avoid conflict with PR alextselegidis#1479
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As requested in #1406, this PR will persist the booking price when made & allow the admins to override the price when adding a booking from the backend modal. This will now allow me to use this field when building #710
If the user changes the selected service or provider, it will override the custom entry in the price field immediately within the modal view; this is partially by design as there is not a specific custom price override or discount field that could be used to calculate a discounted total.
I will be deploying this locally tomorrow after rolling back my installation from using 'total_cost', but opening for feedback & review 🙏