Remove the restriction on printing for dirvish-data-for-dir
#266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The line ```elisp (format "%S" `(message "%s" ,(dirvish--dir-data-getter dir))) ``` Sometimes generates something like: ```elisp (with-temp-buffer (let ((hash ...) (bk ...)) (dolist (file ...) (let* ... ... ...)) (prin1 (cons bk hash) (current-buffer))) (buffer-substring-no-properties (point-min) (point-max))) ``` which is then sent to `emacs -Q` to run but of course it fails to run because of the ellipses all over the code. These ellipses are managed by `print-length` and `print-level` variables which are when set to `nil` never generates ellipses. Possibly we need to set these variables to `nil` whenever we generate code using `(format "%S")` but I haven't had any problems with other parts so far.
hlissner
added a commit
to hlissner/dirvish
that referenced
this pull request
Aug 7, 2024
|
Oh thank you so much for the workaround. |
|
I refactored the background process functions to use async which uses the same safe guards and more. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The line
Sometimes generates something like:
which is then sent to
emacs -Qto run but of course it fails to run because of the ellipses all over the code. These ellipses are managed byprint-lengthandprint-levelvariables which are when set tonilnever generates ellipses.Possibly we need to set these variables to
nilwhenever we generate code using(format "%S")but I haven't had any problems with other parts so far.