Fix custom type specifications #239
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think this warning can be silenced with something like diff --git a/dirvish.el b/dirvish.el
index 0eb16bd..f3b0b6a 100644
--- a/dirvish.el
+++ b/dirvish.el
@@ -163,8 +163,9 @@ and its ARGS is issued to open the file externally. The special
placeholder \"%f\" in the ARGS is replaced by the FILENAME at
runtime. Set it to nil disables this feature."
:group 'dirvish
- :type '(alist :key-type ((repeat string) :tag "File extensions")
- :value-type ((repeat string) :tag "External command and args")))
+ :type '(alist :key-type (repeat :tag "File extension" string)
+ :value-type (cons (string :tag "External command")
+ (repeat :tag "Args for the command" string))))
(defcustom dirvish-reuse-session t
"Whether to reuse the hidden sessions.
|
aikrahguzar
reviewed
Sep 29, 2023
extensions/dirvish-icons.el
Outdated
|
|
||
| (defcustom dirvish-nerd-icons-offset 0.00 | ||
| "Icon's vertical offset used for `nerd-icons' backend. | ||
| Set it to nil to use the default offset from `nerd-icons'." | ||
| :group 'dirvish :type '(choice (float nil))) | ||
| :group 'dirvish :type '(choice (float (const nil)))) |
There was a problem hiding this comment.
Should probably be '(choice float (const nil))
extensions/dirvish-peek.el
Outdated
|
|
||
| (defcustom dirvish-peek-categories '(file project-file library) | ||
| "Minibuffer metadata categories to show file preview." | ||
| :group 'dirvish :type 'list) | ||
| :group 'dirvish :type '(list symbol)) |
There was a problem hiding this comment.
Going by the default value the type should probably be (repeat symbol).
extensions/dirvish-yank.el
Outdated
| @@ -65,7 +65,7 @@ The value can be a symbol or a function that returns a fileset." | |||
|
|
|||
| (defcustom dirvish-yank-rsync-args '("--archive" "--verbose" "--compress" "--info=progress2") | |||
| "The default options for the rsync command." | |||
| :type 'list :group 'dirvish) | |||
| :type '(list string) :group 'dirvish) | |||
There was a problem hiding this comment.
Also here the type should probably be (repeat string).
|
@aikrahguzar Thanks for your feedback. I've adjusted the commit accordingly. |
|
I've stuck to just |
|
@tarsius, thanks but I don't see any changes :) |
|
Ups, forgot to push. |
hlissner
added a commit
to hlissner/dirvish
that referenced
this pull request
Aug 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Emacs' "master" branch, the byte-compiler recently learned to recognize more common mistakes in custom type specifications. This pull-requests fixes most of them, but there are two exceptions, you still have to find a solution for:
This pr also includes the commits from my earlier prs, #220 and #227.