-
-
Notifications
You must be signed in to change notification settings - Fork 216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OPENPROJECT | Add openproject #1387
Conversation
still WIP. will have to test this and volumes configurations ;) |
@alexbelgium I can't understand why |
add volumes for data retenction
Really nice thanks! I'm off for a couple days and will gladly help when I'll be back if needed! |
I think codacy is
Actually it is useless things that I have white listed on my own codacy but it seems it doesn't transfer to your checks... So you can just ignore it :) |
the sad thing is that I can't try that. could we try and merge this to see if this is working if you thing everything is ok? |
Oh sorry I missed your message i'll merge right now!! And thanks very much for the coffees on PayPal! |
Hi! I've tested it but you miss an instruction to start the actual app : you should have a file in rootfs/etc/cont-init.d/99-run.sh that would contain the startup code For the moment it just builds and executes the basic scripts but the app doesn't start. The best way to see what to put in the run.sh file is to check the entrypoint or cmd of the initial dockerfile |
Here is the command "./docker/prod/entrypoint.sh" taken from https://hub.docker.com/layers/openproject/openproject/dev/images/sha256-3eeb74aa73c6191c397c9c31c77176f350dc6d0722551dbd8fa3ad964ebbb8a2?context=explore |
It actually is likely "exec /app/docker/prod/supervisord /app/docker/prod/entrypoint.sh" but then it says an error about file but found while starting |
You can troubleshoot and test by adding in the sh file of your /config either sleep infinity and then test commands from portainer console, or
|
what if I remove the what are the pro and cons? |
it all depends how is built the upstream container :
For you it would be : |
btw if you want to launch yourself the building of a new addon version you can just open a new pull request with the changes and write |
I will try with the third option and use the magic |
I have the project of add openproject, so I added openproject to the project
XD