Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(create-electron): Changed names for electron main and preload files #31

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

NaspoDev
Copy link

Description

I find that the project structure of electron apps would be a lot more clear if the main process file is named main.js, and the preload file named preload.js. Currently, they are both named index.js, which is a bit confusing/unorganized.

This pull request has, for all frameworks:

  • Changed the names of all main process files from index.js/ts to main.js/ts.
  • Changed the names of all preload files from index.js/ts to preload.js/ts. (This includes preload.d.ts).
  • Updated the BrowserWindow's webPreferences.preload option to reflect the name change in the path.
  • Updated the package.json main file name.

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

main process file changed from  index.js/ts to main.js/ts | preload files from index.js/ts to preload.js/ts. (including .d.ts files). The webPreferences preload config was also update to reflect this new name change.
@NaspoDev NaspoDev changed the title Changed names for electron main and preload files refactor(create-electron): Changed names for electron main and preload files Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant