Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: parameter to add a space under the calendar #871

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

FDuhen
Copy link

@FDuhen FDuhen commented May 2, 2024

Currently, if you use the markerMargin parameter in order to add some top margin, the rendering of the Marker can be cropped at the bottom of the Calendar.
Capture d’écran 2024-05-02 à 09 17 42

The proposed solution would be to increase the rowHeight parameter in order to correctly handle the display of the markers. Sadly, this solution won't fit every needs.
I ended up with the solution of adding a new parameter that I called bottomSpace (could have been bottomMargin, but I thought that this name was misleading) which job is to add some more space in the AnimatedContainer rendering the Calendar, and thus allowing to correctly draw the Markers.
Capture d’écran 2024-05-02 à 09 17 54

There might be a sexier solution to this issue, but it'd ask a lot more work and brain juice, alongside with a lot more of refactoring. With this update, it won't break anything to the current users

@FDuhen
Copy link
Author

FDuhen commented May 2, 2024

Related to this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant