Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature / Add element states to semantics on cells #834

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

parisbs
Copy link

@parisbs parisbs commented Nov 28, 2023

Description

  • Add enabled and checked properties to semantics on cells to improve accessibility

How Has This Been Tested?

  1. Run the example app
  2. Enable any screen reader available in your device (Talkback for Android, VoiceOver for iOS, Narrator or NVDA for Windows)
  3. Go to range, multi or complex example page
  4. Select/unselect a day or a range of days
  5. The screen reader should announce the selected days as a checked checkbox
  6. For unselected days nothing change

Type of Change

  • Feature

Notes

Semantics uses checked instead selected because selected is not announced correctly on web with some screen readers, to prevent to overflow the semantic UI with a lot of unchecked semantic checkboxes the checked property is only setted when the day is selected or is under a range.
This changes don't handle the logic to make the range selection accessible because there are so many ways to manage this so That is the responsibility of each developer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant