Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support matplotlib 3.9.0 #377

Merged
merged 4 commits into from
Jul 4, 2024
Merged

Support matplotlib 3.9.0 #377

merged 4 commits into from
Jul 4, 2024

Conversation

xiki-tempula
Copy link
Collaborator

@xiki-tempula xiki-tempula linked an issue Jul 3, 2024 that may be closed by this pull request
flamel fails the first time I ran it alchemistry/flamel#28
Closed
@xiki-tempula
Copy link
Collaborator Author

@orbeckst Do you mind do a quick review? I will release this version after the PR is merged as this is a critical bug fix.

@xiki-tempula xiki-tempula mentioned this pull request Jul 3, 2024
Closed
@codecov Codecov
Copy link

codecov bot commented Jul 3, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.83%. Comparing base (584588c) to head (d13bc12).

Additional details and impacted files 
@@           Coverage Diff           @@
##           master     #377   +/-   ##
=======================================
  Coverage   98.83%   98.83%           
=======================================
  Files          28       28           
  Lines        1895     1895           
  Branches      407      407           
=======================================
  Hits         1873     1873           
  Misses          2        2           
  Partials       20       20

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

orbeckst
orbeckst approved these changes Jul 3, 2024
View reviewed changes
Copy link
Member

@orbeckst orbeckst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@orbeckst orbeckst self-assigned this Jul 3, 2024
orbeckst
orbeckst reviewed Jul 3, 2024
View reviewed changes
CHANGES Outdated Show resolved Hide resolved
@orbeckst orbeckst enabled auto-merge (rebase) July 3, 2024 20:58
@orbeckst orbeckst disabled auto-merge July 3, 2024 20:58
@orbeckst orbeckst enabled auto-merge (squash) July 3, 2024 20:59
orbeckst
orbeckst requested changes Jul 3, 2024
View reviewed changes
Copy link
Member

@orbeckst orbeckst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the minimum version of matplotlib that is working with this change? Update pyproject.toml, please.

We will also need this information for the conda-forge package.

@sidneypaulymer
Copy link

LGTM! I reinstalled the bugfix branch into a fresh environment, and flamel now completes without an error. Thanks! My only concern has already been raised: what is the minimum version of matplotlib that will support this change?

@xiki-tempula
Copy link
Collaborator Author

minimum version of matplotlib is 3.7.

orbeckst
orbeckst approved these changes Jul 4, 2024
View reviewed changes
Copy link
Member

@orbeckst orbeckst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good, please squash-merge when you want.

@orbeckst orbeckst merged commit 5a73cc4 into master Jul 4, 2024
11 checks passed
@orbeckst orbeckst deleted the 28-flamel-fails-the-first-time-i-ran-it branch July 4, 2024 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orbeckst orbeckst orbeckst approved these changes

Assignees

@orbeckst orbeckst

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

flamel fails the first time I ran it
3 participants
@xiki-tempula @sidneypaulymer @orbeckst