Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix lights being identified as switches (#2204) #2260

Merged
merged 4 commits into from
May 30, 2024

Conversation

BenGrimm42
Copy link
Contributor

fix: commit e3da18b to support switches as lights (if redeclared that way in the Alexa app) was incomplete due to conflicting change in commit 2344bcf (#2204)

feat: handle SMARTPLUG as lightswitch when defined in Alexa app as type "LIGHT" (ie. SONOFF ZBMINI Extreme Zigbee switches or real smart plugs when used for lamps)
fix: commit e3da18b to support switches as lights (if redeclared that way in the Alexa app) was incomplete due to conflicting change in commit 2344bcf (alandtse#2204)
@BenGrimm42
Copy link
Contributor Author

Sorry! Needed to fix my previous change again.
When I made the intial change for commit e3da18b I did (and tested) that based on the 4.9.2 release version and not on the current dev branch. And the commit 2344bcf (#2204), which was already on the dev branch, unfortunately makes my change useless, as it now handled all switches from all manufacturers and thus also "stealing" the ones that are redeclared as lights.
The new change now excludes the "lights" from the is_switch handler, so that they get again through to the later happening is_light handler.

@BenGrimm42
Copy link
Contributor Author

But at least that didn't break anything in 4.10, the "light" switches where just again not found as lights, but just as switches.

@alandtse alandtse changed the title fix: commit e3da18b to support switches as lights (if redeclared that way in the Alexa app) was incomplete due to conflicting change in commit 2344bcf (#2204) fix: fix lights being identified as switches (#2204) May 30, 2024
@alandtse alandtse merged commit 9f08952 into alandtse:dev May 30, 2024
1 check passed
alandtse added a commit that referenced this pull request May 30, 2024
fix: fix lights being identified as switches (#2204) (#2260)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants