Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor tests improving coverage #19

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

mjhanninen
Copy link

Hi, Alan! While trying to do some other modifiations to the library I realized that the existing tests didn't cover the actual interaction with the local storage. So this PR aims to fix that. In particular this PR:

  • Adds support for immediate execution of the storage operation.
  • Adds support for generating synthetic storage update events (in addition to generating just the remove events).
  • Refactors the tests to cover the actual storage operations against the local storage (still leaving the session storage outside the coverage)

Resulting in immediate execution instead of debouncing.
In order to facilitate testing
The existing tests concentrated more on properties of an atom and didn't
cover the actual local storage mechanism.
@dijonkitchen
Copy link

Any updates?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants