Address pinned issues #2
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 7, 2023 16:26
dsame
reviewed
Jun 22, 2023
| @@ -1,5 +1,5 @@ | |||
| import {Issue} from '../classes/issue'; | |||
|
|
|||
| export function isPullRequest(issue: Readonly<Issue>): boolean { | |||
| return !!issue.pull_request; | |||
| return !!issue.pullRequest; | |||
There was a problem hiding this comment.
I would prefer Boolean(issue.pullRequest)
see https://eslint.org/docs/latest/rules/no-implicit-coercion
dsame
reviewed
Jun 22, 2023
| query ($owner: String!, $repo: String!, $issueEndCursor: String, $pullRequestEndCursor: String) { | ||
| repository(owner: $owner, name: $repo) { | ||
| issues(first: 100, after: $issueEndCursor, states: OPEN) { | ||
| nodes { |
There was a problem hiding this comment.
some day it become necessary to fetch number to use it as issue ID
| created_at: IsoDateString; | ||
| updated_at: IsoDateString; | ||
| createdAt: IsoDateString; | ||
| updatedAt: IsoDateString; |
There was a problem hiding this comment.
As soon as the rest API is dropped it might have sense to make these properties Date to avoid the converting to dates here and there throught the code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Now issues and pull request are received through GraphQL API. This is needed because default API has no
isPinnedfield.Now action skips any issue that is pinned
Related issue:
actions#990
Check list: