Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix wrong dots behavior #2354

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Fix wrong dots behavior #2354

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3b0be06
Add currentSlide property to dotProps
jimbokid Feb 17, 2024
5f133b1
Update package metadata
jimbokid Feb 23, 2024
f35fc8a
Update package metadata
jimbokid Feb 23, 2024
2a6c8d3
Update package version and repository URL
jimbokid Feb 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "react-slick",
"version": "0.30.2",
"name": "react-slick-fixed-dots",
"version": "0.30.4",
"description": " React port of slick carousel",
"main": "./lib",
"files": [
Expand All @@ -21,11 +21,11 @@
"test-watch": "jest --watch",
"clear-jest": "jest --clearCache"
},
"author": "Kiran Abburi",
"author": "Yurii Kovalchuk",
"license": "MIT",
"repository": {
"type": "git",
"url": "git+https://github.com/akiran/react-slick.git"
"url": "git+https://github.com/jimbokid/react-slick-fixed-dots.git"
},
"keywords": [
"slick",
Expand Down
3 changes: 2 additions & 1 deletion src/inner-slider.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -679,7 +679,8 @@ export class InnerSlider extends React.Component {
clickHandler: this.changeSlide,
onMouseEnter: pauseOnDotsHover ? this.onDotsLeave : null,
onMouseOver: pauseOnDotsHover ? this.onDotsOver : null,
onMouseLeave: pauseOnDotsHover ? this.onDotsLeave : null
onMouseLeave: pauseOnDotsHover ? this.onDotsLeave : null,
currentSlide: Math.round(dotProps.currentSlide)
};
dots = <Dots {...dotProps} />;
}
Expand Down