Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix clicking next/prev arrows when initialSlide is not 0 #2029

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jorrit
Copy link
Contributor

@jorrit jorrit commented May 7, 2021

This PR fixes #1946.

This bug got introduced with change 1c3d70c. When initialSlide is set, targetSlide was not set to the right value. This is fixed.

Also, I think the intended change of 1c3d70c can be implemented slightly simpler, by just checking if the new value is out of the allowed bounds.

@felipe-gustavo
Copy link

Please, merge this

@apntzls
Copy link

apntzls commented Jul 19, 2021

Hello all, what's the status of this PR, I'm needing this fixed.

@JoaoCSR
Copy link

JoaoCSR commented Aug 20, 2021

Is there any way we can get a timeline on when to expect this merged?

@yenienRey
Copy link

Please, merge this +1

@dramoturg
Copy link

Do you have any news?

@gtb104
Copy link

gtb104 commented Jul 15, 2022

This repo has had very little movement in the last year. I see there are many open pull requests just waiting to be merged. Who has write access? If it's only @akiran, can we petition to get others to help maintain this project?

@akiran
Copy link
Owner

akiran commented Jul 21, 2022

This issue is already fixed

@akiran akiran closed this Jul 21, 2022
@akiran akiran reopened this Jul 21, 2022
@gtb104
Copy link

gtb104 commented Aug 19, 2022

If it’s already fixed, could you please point to the PR and release that addresses this issue? Ant design uses this library in their Carousel component. If there’s a specific version they should be at, then I’ll make a PR to pull in the correct version on their repo.

@AttackXiaoJinJin
Copy link

come on, it's 2022 !!

@nh-teemukorkalainen
Copy link

This is still an issue on 2024.

If slider uses beforeChange hook, the next index is always zero and, when set, the current index has the value of the initialSlide-prop. Additionally afterChange hook’s current index is also always zero, even if initialSlide-prop is something else than zero.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Changing slide works incorrect when infinite is false and initialSlide > 1