-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix clicking next/prev arrows when initialSlide is not 0 #2029
base: master
Are you sure you want to change the base?
Conversation
Please, merge this |
Hello all, what's the status of this PR, I'm needing this fixed. |
Is there any way we can get a timeline on when to expect this merged? |
Please, merge this +1 |
Do you have any news? |
This repo has had very little movement in the last year. I see there are many open pull requests just waiting to be merged. Who has write access? If it's only @akiran, can we petition to get others to help maintain this project? |
This issue is already fixed |
If it’s already fixed, could you please point to the PR and release that addresses this issue? Ant design uses this library in their Carousel component. If there’s a specific version they should be at, then I’ll make a PR to pull in the correct version on their repo. |
come on, it's 2022 !! |
This is still an issue on 2024. If slider uses |
This PR fixes #1946.
This bug got introduced with change 1c3d70c. When
initialSlide
is set,targetSlide
was not set to the right value. This is fixed.Also, I think the intended change of 1c3d70c can be implemented slightly simpler, by just checking if the new value is out of the allowed bounds.