Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

working innertube videoInfo, speed up whitelistCheck #1258

Draft
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

mchangrh
Copy link
Contributor

@mchangrh mchangrh commented Apr 1, 2022

changes

  • revive videoInfo [info][external] innertube fetching #1257
  • remove additional regex check on getChannelID
  • race document and videoInfo on whitelistCheck
    • innertube wins on force reload, document on navigation
    • not a single video went by without catching 0s preview with 9ms ping to youtube
  • remove music_video warning

blocked by #1261


todo

  • add timeout race

To test this pull request, follow the instructions in the wiki.


- purge getVideoInfo as data structure is outdated + currently impossible ajayyy#1257
- remove additional regex check on getChannelID
@mchangrh mchangrh marked this pull request as draft April 1, 2022 06:49
@mchangrh mchangrh marked this pull request as ready for review April 1, 2022 23:55
@mchangrh mchangrh changed the title purge getVideoInfo, remove double regex working innertube videoInfo, speed up whitelistCheck Apr 1, 2022
@mchangrh

This comment was marked as outdated.

@mchangrh mchangrh marked this pull request as draft April 3, 2022 01:52
@mchangrh
Copy link
Contributor Author

mchangrh commented Apr 3, 2022

Spreadsheet with differences in speed between XHR and document fetching

Summary for future

  • force reloading - XHR > Document 10/10
  • Channel hopping - XHR > Document 7/10
  • Same channel - XHR > Document 8/10

Average Times

XHR Document Video Ready
Force Reload 427 1853.6 439.3
Channel Hopping 467.7 575.5 361.1
Same Channel 401.3 533.5 417.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants