Proof of concept decouple Gradle JDK from compiling JDK #234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note: * Gradle 8.x supports 8-23 for running Gradle * Gradle 9.x scheduled to support 17-23 for running Gradle https://docs.gradle.org/current/userguide/compatibility.html
TWiStErRob
commented
Sep 29, 2024
Comment on lines
-439
to
-442
| public fun addFirst (Lcom/github/ajalt/mordant/rendering/Span;)V | ||
| public synthetic fun addFirst (Ljava/lang/Object;)V | ||
| public fun addLast (Lcom/github/ajalt/mordant/rendering/Span;)V | ||
| public synthetic fun addLast (Ljava/lang/Object;)V |
There was a problem hiding this comment.
This is interesting, probably default interface methods?
TWiStErRob
commented
Sep 29, 2024
Comment on lines
+54
to
+57
| javaLauncher = javaToolchains.launcherFor { | ||
| languageVersion.set(JavaLanguageVersion.of(22)) | ||
| vendor = JvmVendorSpec.AZUL // Zulu | ||
| } |
ajalt
reviewed
Sep 29, 2024
| @@ -40,7 +40,7 @@ jobs: | |||
| - uses: actions/setup-java@v4 | |||
| with: | |||
| distribution: 'zulu' | |||
| java-version: 22 | |||
There was a problem hiding this comment.
What's the advantage of changing this version?
There was a problem hiding this comment.
It'll actually slow down builds because you'll install 17 only to then have to install 22.
There was a problem hiding this comment.
Yeah, totally correct. I changed it only to prove that the setup is now independent of what JDK is running the Gradle process.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note:
https://docs.gradle.org/current/userguide/compatibility.html
I ran the CI here: TWiStErRob#1 (https://github.com/TWiStErRob/mordant/actions/runs/11092440186)
This enables developers (contributors) to have almost any JDK they want, not just 22/23.
Feel free to close this if you're not interested, it just came out of me trying to build the project and investigate my issues.