Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set unique android.namespaces for all the extensions #46

Merged
merged 2 commits into from
Oct 13, 2023

Conversation

frett
Copy link
Contributor

@frett frett commented Oct 13, 2023

these values are what were originally set in the AndroidManifest.xml. It doesn't matter too much what they are set to, just as long as they are unique and don't collide with other namespaces

Fixes #45

these values are what were originally set in the AndroidManifest.xml
@ajalt
Copy link
Owner

ajalt commented Oct 13, 2023

Excellent, thank you!

Do you know what the backwards compatibility is for changing these?

@frett
Copy link
Contributor Author

frett commented Oct 13, 2023

It would change the location of the BuildConfig class generated for each extension (which actually would revert to the location that was in 3.2.1).But I'm not aware of any use of the generated BuildConfig for those extensions

@JakeWharton
Copy link

You should consider disabling the BuildConfig generation. It's off-by-default in AGP 8 for libraries anyway.

@frett
Copy link
Contributor Author

frett commented Oct 13, 2023

@ajalt I can add that to this PR if you want

@ajalt
Copy link
Owner

ajalt commented Oct 13, 2023

yes please, if it's not necessary, let's get rid of it

@frett
Copy link
Contributor Author

frett commented Oct 13, 2023

I think the namespace change should stay to prevent any future conflicts. I know the R class is also generated under that namespace, but you aren't currently including any android resources that would be affected by that

@frett frett changed the title Set unique andorid.namespaces for all the extensions Set unique android.namespaces for all the extensions Oct 13, 2023
@ajalt ajalt merged commit c37cee3 into ajalt:master Oct 13, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Duplicate class error when using multiple android extensions
3 participants