Upgrade to @httptoolkit/osx-find-executable 2.x
#10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vweevers
requested changes
Apr 28, 2023
The previous version emits an npm-audit warning, for the change at httptoolkit/osx-find-executable@20fb1e2c, which is a breaking change that can't be patched downstream as it is incompatible with the current way the function is called.
Krinkle
force-pushed
the
upgrade-find-exec
branch
from
f227d19
to
ebda097
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous version emits an npm-audit warning, for the change at httptoolkit/osx-find-executable@20fb1e2c, which is a breaking change that can't be patched downstream as it is incompatible with the current way the function is called.
It appears this repo has no tests.
Test plan:
node -e "require('./index.js').detect(console.log)"before/after the change, no difference in output.