Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throw a more meaningful error when TOPPRA fails #5

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

m-decoster
Copy link
Contributor

When wanting to change control flow when time_parameterize_toppra fails, we need to catch ValueErrors, but these can also come from different parts of the code base. To make catching the right error easier, I've defined a custom error type, such that downstream code can use

try:
    # ...
except TimeParameterizationError:
    # ...

to catch only that specific error.

Note

  • Perhaps there are other exceptions too that we want to handle in this way.
  • I still need to update the docstring of the function.

@m-decoster m-decoster marked this pull request as ready for review June 26, 2024 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant