Fix thread safety issue in consistency pipeline #775
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbrooks-stripe
force-pushed
the
jbrooks-consistency-thread-safety
branch
from
eb19af5 to
d24a7b6
Compare
davidhan-stripe
approved these changes
Jun 20, 2024
pengyu-hou
reviewed
Jun 21, 2024
| @@ -310,6 +308,12 @@ class Fetcher(val kvStore: KVStore, | |||
| val loggingTry: Try[Unit] = joinCodecTry.map(codec => { | |||
| val metaData = codec.conf.join.metaData | |||
| val samplePercent = if (metaData.isSetSamplePercent) metaData.getSamplePercent else 0 | |||
|
|
|||
| // Exit early if sample percent is 0 | |||
| if (samplePercent == 0) { | |||
|
Ah missed this, I will fix it in #857! |
Thanks @hzding621. We can close this PR after yours is merged. |
hzding621
added a commit
that referenced
this pull request
Oct 7, 2024
* make logging codec thread safe * cherry-pick #775 --------- Co-authored-by: Haozhen Ding <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This changes things such that a new instance of the AvroCodec is used instead of re-using the same one across requests.
Why / Goal
To log feature values for the consistency pipeline, we use AvroCodec to encode and hash keys, but the Avro encoding here is not thread safe.
Test Plan
Checklist
Reviewers