Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Let exceptions from ecVerifySig() handled properly #1271

Merged
merged 2 commits into from
Apr 30, 2024
Merged

Let exceptions from ecVerifySig() handled properly #1271

merged 2 commits into from
Apr 30, 2024

Conversation

platfowner
Copy link
Member

Change summary:

  • Let verifyTransaction() handle exceptions
  • Let verifySignedMessage() handle exceptions

Related issues:

@platfowner platfowner changed the title Let exceptions handled properly from ecVerifySig() Let exceptions from ecVerifySig() handled properly Apr 30, 2024
jiyoung-an
jiyoung-an approved these changes Apr 30, 2024
View reviewed changes
Copy link
Member

@jiyoung-an jiyoung-an left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks !

@platfowner
Copy link
Member Author

Thanks for the review! @jiyoung-an Now merging..

@platfowner platfowner merged commit f00054d into develop Apr 30, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jiyoung-an jiyoung-an jiyoung-an approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@platfowner @jiyoung-an