Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make ain_getTransactionByHash() return tx execution result #1203

Merged
merged 9 commits into from
Aug 18, 2023
Merged

Make ain_getTransactionByHash() return tx execution result #1203

merged 9 commits into from
Aug 18, 2023

Conversation

platfowner
Copy link
Member

@platfowner platfowner commented Aug 17, 2023 •
edited
Loading

Change summary:

  • Make ain_getTransactionByHash() return tx execution result
  • Add IN_BLOCK transaction state
  • Update the states of the transactions in blocks when they're executed

Related issues:

@platfowner platfowner added the enhancement New feature or request label Aug 17, 2023
shyun-comcom
shyun-comcom approved these changes Aug 18, 2023
View reviewed changes
Copy link
Member

@shyun-comcom shyun-comcom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

woomurf
woomurf approved these changes Aug 18, 2023
View reviewed changes
Copy link
Member

@woomurf woomurf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks!

@platfowner
Copy link
Member Author

Thanks for the review. @shyun-comcom @woomurf Now merging..

@platfowner platfowner merged commit bd700d2 into develop Aug 18, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@woomurf woomurf woomurf approved these changes

@shyun-comcom shyun-comcom shyun-comcom approved these changes

@kriii kriii Awaiting requested review from kriii

@minsulee2 minsulee2 Awaiting requested review from minsulee2

@akastercomcom akastercomcom Awaiting requested review from akastercomcom

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@platfowner @woomurf @shyun-comcom