Feature/kriii/enhance dockerize #1167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
kriii
commented
May 9, 2023
kriii
commented
- Add json rpc urls (tracker, peer candidate) to start_node_docker.sh
- Add mount a volume readme
platfowner
reviewed
May 9, 2023
README.md
Outdated
| @@ -170,6 +170,13 @@ You can use some environment variables, and these have the following options. | |||
| -e ACCOUNT_INJECTION_OPTION={private_key|keystore|mnemonic} | |||
| -e SYNC_MODE={fast|full|peer} | |||
| -e STAKE=<YOUR_TARGET_STAKE> | |||
| -e HOSTING_ENV={gcp|aws} | |||
There was a problem hiding this comment.
Could you add 'local' and 'comcom'?
platfowner
reviewed
May 9, 2023
README.md
Outdated
| 1. Want to preserve blockchain data in the docker container when changing the docker image due to an update. | ||
| 2. Want to save your keystore file in the docker container when injecting your account into the blockchain automatically. | ||
| ``` | ||
| -v <YOUR_VOLUME>:/home |
There was a problem hiding this comment.
Can this be changed to <YOUR_VOLUME>:/home/ain_blockchain_data ?
|
PTAL, Thanks! |
platfowner
approved these changes
May 10, 2023
|
Now merged! Thanks for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.