Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set chain id properly in blockchain node param config scripts #1157

Merged
merged 1 commit into from
Apr 25, 2023
Merged

Set chain id properly in blockchain node param config scripts #1157

merged 1 commit into from
Apr 25, 2023

Conversation

platfowner
Copy link
Member

@platfowner platfowner commented Apr 24, 2023 •
edited
Loading

@platfowner platfowner added the bug Something isn't working label Apr 24, 2023
woomurf
woomurf reviewed Apr 25, 2023
View reviewed changes
config_client_api_ip_whitelist.sh
function config_node() {
local node_index="$1"
local node_ip_addr=${IP_ADDR_LIST[${node_index}]}

printf "\n\n<<< Configuring ip whitelist of node $node_index ($node_ip_addr) >>>\n\n"

KEYSTORE_FILE_PATH="$KEYSTORE_DIR/keystore_node_$node_index.json"
CONFIG_NODE_CMD="node tools/api-access/$COMMAND_NODE_JS_FILE $node_ip_addr 0 keystore $KEYSTORE_FILE_PATH"
CONFIG_NODE_CMD="node tools/api-access/$COMMAND_NODE_JS_FILE $node_ip_addr $CHAIN_ID keystore $KEYSTORE_FILE_PATH"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

woomurf
woomurf approved these changes Apr 25, 2023
View reviewed changes
Copy link
Member

@woomurf woomurf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks!

ehgmsdk20
ehgmsdk20 approved these changes Apr 25, 2023
View reviewed changes
Copy link
Member

@ehgmsdk20 ehgmsdk20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@platfowner
Copy link
Member Author

Thanks for the review. Now merging..

@platfowner platfowner merged commit 738ece4 into develop Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@woomurf woomurf woomurf approved these changes

@ehgmsdk20 ehgmsdk20 ehgmsdk20 approved these changes

@kriii kriii Awaiting requested review from kriii

@minsulee2 minsulee2 Awaiting requested review from minsulee2

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@platfowner @woomurf @ehgmsdk20