Skip to content
This repository has been archived by the owner on Jan 23, 2024. It is now read-only.

Commit

Permalink
feat: added sampling rate configuration
Browse files Browse the repository at this point in the history
  • Loading branch information
AH-dark committed Jan 7, 2024
1 parent 5917773 commit f7ad182
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 7 deletions.
6 changes: 1 addition & 5 deletions cmd/generator/main.go
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,10 @@ import (
"context"
"flag"
"fmt"

"github.com/AH-dark/bytestring"
md5simd "github.com/minio/md5-simd"
"github.com/uptrace/opentelemetry-go-extra/otelzap"
"go.opentelemetry.io/otel"
"go.uber.org/fx"
"go.uber.org/zap"

Expand All @@ -17,7 +17,6 @@ import (
)

var ctx = context.Background()
var tracer = otel.Tracer("github.com/AH-dark/gravatar-with-qq-avatar/cmd/generator")

var (
from = int64(10000)
Expand All @@ -31,9 +30,6 @@ func init() {
}

func generate(ctx context.Context, md5QQMappingRepo dal.MD5QQMappingRepo) error {
ctx, span := tracer.Start(ctx, "cmd.generator.generate")
defer span.End()

svr := md5simd.NewServer()
defer svr.Close()

Expand Down
7 changes: 5 additions & 2 deletions common/observability/trace.go
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ func NewTraceProvider(
ctx, span := tracer.Start(ctx, "observability.NewTraceProvider")
defer span.End()

tp := tracesdk.NewTracerProvider(
opts := []tracesdk.TracerProviderOption{
tracesdk.WithResource(resource),
tracesdk.WithBatcher(
exporter,
Expand All @@ -83,7 +83,10 @@ func NewTraceProvider(
tracesdk.WithExportTimeout(vip.GetDuration("observability.trace.export_timeout")),
tracesdk.WithMaxQueueSize(vip.GetInt("observability.trace.max_queue_size")),
),
)
tracesdk.WithSampler(tracesdk.TraceIDRatioBased(vip.GetFloat64("observability.trace.sampling_rate"))),
}

tp := tracesdk.NewTracerProvider(opts...)

lc.Append(fx.Hook{
OnStop: func(ctx context.Context) error {
Expand Down

0 comments on commit f7ad182

Please sign in to comment.