-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[aform] adate refactor #98
Conversation
@Alchez I'm stuck on a couple of issues here:
Can you take a look at this and give me a debrief of the mistakes? |
The emits should now match up with the other form components. Checkbox still seems to be using a slightly different emit event but I haven't changed it in this iteration yet. The As for styling, I'm not too sure how to approach that one. Let's discuss on a call tonight? |
f6d3d64
to
da0d358
Compare
@Alchez Keyboard navigation
|
@Alchez Let's refresh this one |
Coverage Report for ./atable
File Coverage
|
@agritheory, there seems to be a dependency resolution issue with I am tracking an open issue that was active a couple of weeks ago, so I'll try the workarounds mentioned in that. |
@Alchez Some issues I noticed in the ADatePicker story:
In the ADate story I expected to see the ADatePicker interface show below the input. It is also very wide, is that because it's not in a fieldset? @crabinak Design dilemma: how do we visually communicate "today", "selected" and "cursor" in this interface without relying on a theme color? |
@agritheory I'll take a look but, I'm thinking something along the lines of: Today: Filled background. Or vice versa with selected and cursor, I just think of the marching ants border of selection tools which is why I went for dashes. Dashes might look terrible, so it might be a thicker or thinner border instead. I'll try a few options and see what works. |
I can replicate this on my end, but I'm not sure why it's happening. I'm guessing since the pgUp event listener is loaded up on every cell, it gets triggered for both tables everytime it's pressed?
I've added a commit that sets up this behaviour.
I looked into the
I think that might be true. I'm using a simple
Technically this does work for the ADate input, but if we want ADate to work with ADatePicker, then I think we'll have to design something. Maybe an |
@Alchez The UX I think we want is based on the user tabbing versus clicking into a date field. If they've clicked on it the field we can assume they want a datepicker interface and should only evaporate it after they blur from the field. On the other hand, when they tab into the field, we can assume hands stay on the keyboard and we can respect their text-based input. |
I don't think we want page up/down listeners on every cell, is this based on the utility composable? |
@agritheory I just updated the style on the date picker. I bolded and underlined the current day so that is it emphasized but does not overpower/compete with the selected day. Let me know if something isn't looking right. Additionally, all days that have already passed could be given a lighter gray color, but I wasn't sure if the user would still be able to select these days (in which case graying them out might give them the impression they are unselectable). |
:id="uuid" | ||
:disabled="readonly" | ||
:required="required" | ||
:value="inputDate" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@agritheory I had to move the map from v-model
to value
since the two-way sync was causing some issues with the v-model
setup in the story. Let's discuss this change.
@agritheory I was looking to use I tried implementing it in just the Histoire story as well as trying to apply it to the Should we switch approaches and apply/remove keyboard navigation listeners conditionally? Maybe using What do you suggest? |
@Alchez I think its worth experimenting with |
No description provided.