Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Promote #178

Merged
merged 11 commits into from
Dec 12, 2023
Merged

Promote #178

merged 11 commits into from
Dec 12, 2023

Conversation

stdavis
Copy link
Member

@stdavis stdavis commented Dec 12, 2023

Most of these enhancements and fixes were requested by CityWorks so that West Jordan could use our locator in their product. The main issue was that they were sending most, if not all, requests as posts.

stdavis and others added 11 commits December 8, 2023 11:53
Includes a refactor to move the helper function out into the utils module.
This was requested by CityWorks developers.
Bumps the ci-dependencies group with 1 update: [agrc/cloud-run-docker-deploy-composite-action](https://github.com/agrc/cloud-run-docker-deploy-composite-action).

- [Release notes](https://github.com/agrc/cloud-run-docker-deploy-composite-action/releases)
- [Changelog](https://github.com/agrc/cloud-run-docker-deploy-composite-action/blob/main/CHANGELOG.md)
- [Commits](agrc/cloud-run-docker-deploy-composite-action@v1...v2)

---
updated-dependencies:
- dependency-name: agrc/cloud-run-docker-deploy-composite-action
  dependency-type: direct:production
  update-type: version-update:semver-major
  dependency-group: ci-dependencies
...

Signed-off-by: dependabot[bot] <[email protected]>
Updates the requirements on [psycopg-pool](https://github.com/psycopg/psycopg) and [black](https://github.com/psf/black) to permit the latest version.

Updates `psycopg-pool` to 3.2.0
- [Changelog](https://github.com/psycopg/psycopg/blob/master/docs/news.rst)
- [Commits](psycopg/psycopg@3.1...pool-3.2.0)

Updates `black` to 23.11.0
- [Release notes](https://github.com/psf/black/releases)
- [Changelog](https://github.com/psf/black/blob/main/CHANGES.md)
- [Commits](psf/black@23.9.0...23.11.0)

---
updated-dependencies:
- dependency-name: psycopg-pool
  dependency-type: direct:production
  dependency-group: major-dependencies
- dependency-name: black
  dependency-type: direct:development
  dependency-group: major-dependencies
...

Signed-off-by: dependabot[bot] <[email protected]>
@stdavis stdavis enabled auto-merge (rebase) December 12, 2023 18:38
@stdavis stdavis disabled auto-merge December 12, 2023 18:38
Copy link

codecov bot commented Dec 12, 2023

Codecov Report

Attention: 13 lines in your changes are missing coverage. Please review.

Comparison is base (bfd45ed) 85.39% compared to head (69c556d) 92.50%.
Report is 81 commits behind head on main.

Files Patch % Lines
src/masquerade/main.py 81.08% 6 Missing and 1 partial ⚠️
src/masquerade/providers/open_sgid.py 93.84% 3 Missing and 1 partial ⚠️
src/masquerade/providers/web_api.py 91.66% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #178      +/-   ##
==========================================
+ Coverage   85.39%   92.50%   +7.11%     
==========================================
  Files           3        4       +1     
  Lines         315      347      +32     
  Branches       33       41       +8     
==========================================
+ Hits          269      321      +52     
+ Misses         40       20      -20     
  Partials        6        6              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@steveoh steveoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

.vscode/settings.json Show resolved Hide resolved
setup.py Show resolved Hide resolved
src/masquerade/utils.py Show resolved Hide resolved
tests/test_utils.py Show resolved Hide resolved
@stdavis stdavis enabled auto-merge (rebase) December 12, 2023 22:20
@stdavis stdavis disabled auto-merge December 12, 2023 22:21
@stdavis stdavis merged commit 6126413 into main Dec 12, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants