Skip to content

Commit

Permalink
📝 Add return on error & fix readme headers (#85)
Browse files Browse the repository at this point in the history
  • Loading branch information
Pohfy123 committed Feb 2, 2021
1 parent 5763c4c commit 55ba265
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 4 deletions.
11 changes: 7 additions & 4 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -212,7 +212,8 @@ Find more configuration information in [examples](https://www.github.com/agoda-c
```
> Now, `s2h-example` staging namespace should be created.
<h5 id="minikube-upgrade-components">Upgrade Components</h2>
<h5 id="minikube-upgrade-components">Upgrade Components</h5>
1. Upgrade `redis` and `mariadb` components by using Swagger `http://<minikube_ip>:<node_port>/swagger/index.html#`
- `POST /webhook/component`
```
Expand Down Expand Up @@ -261,7 +262,8 @@ Find more configuration information in [examples](https://www.github.com/agoda-c
```
To save the cluster resources once every upgrade component verification has finished, the running components will be terminated immediately.
<h5 id="minikube-promote-new-active">Promote New Active</h2>
<h5 id="minikube-promote-new-active">Promote New Active</h5>
1. Apply active-promotion
```
kubectl apply -f https://raw.githubusercontent.com/agoda-com/samsahai/master/examples/configs/crds/active-promotion-example.yaml
Expand All @@ -285,7 +287,8 @@ To save the cluster resources once every upgrade component verification has fini
s2h-staging-ctrl-c566b7f66-5q9bh 1/1 Running 0 2m43s
```
<h5 id="minikube-deploy-pull-request-components">Deploy Pull Request Components</h2>
<h5 id="minikube-deploy-pull-request-components">Deploy Pull Request Components</h5>
1. Deploying all components in `redis-bundle` by using Swagger `http://<minikube_ip>:<node_port>/swagger/index.html#`
- `POST /teams/example/pullrequest/trigger`
```
Expand Down Expand Up @@ -423,7 +426,7 @@ To save the cluster resources once every upgrade component verification has fini
"component": "mariadb"
}
```
After this step, you can see the result following [minikube upgrade component](#minikube-upgrade-component) part.
After this step, you can see the result following [minikube upgrade components](#minikube-upgrade-components) part.
##### Promote New Active
1. Apply active-promotion
Expand Down
1 change: 1 addition & 0 deletions internal/samsahai/webhook/pullrequest.go
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,7 @@ func (h *handler) pullRequestWebhook(w http.ResponseWriter, r *http.Request, par
jsonData.CommitSHA, mapCompTag)
if err != nil {
h.error(w, http.StatusInternalServerError, err)
return
}

w.WriteHeader(http.StatusNoContent)
Expand Down

0 comments on commit 55ba265

Please sign in to comment.