Fixed CancellationTokenSource Issue #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szaboopeeter
reviewed
Mar 1, 2024
Agoda.Frameworks.DB/DbRepository.cs
Outdated
| IDbDataParameter[] parameters, | ||
| Func<SqlDataReader, Task<T>> callback) | ||
| { | ||
| return _dbResources.ChooseDb(database).ExecuteAsync(async (connectionStr, _) => | ||
| { | ||
| var stopwatch = Stopwatch.StartNew(); | ||
| Exception error = null; | ||
| var cancellationTokenSource = new CancellationTokenSource(); |
There was a problem hiding this comment.
This is an IDisposable, can we wrap it in using?
Agoda.Frameworks.DB/DbRepository.cs
Outdated
| IDbDataParameter[] parameters, | ||
| Func<SqlDataReader, Task<T>> callback) | ||
| { | ||
| return _dbResources.ChooseDb(database).ExecuteAsync(async (connectionStr, _) => | ||
| { | ||
| var stopwatch = Stopwatch.StartNew(); | ||
| Exception error = null; | ||
| var cancellationTokenSource = new CancellationTokenSource(); | ||
| cancellationTokenSource.CancelAfter(taskCancellationTimeOutInMilliSecs); |
There was a problem hiding this comment.
What is the operation that you want to include in the timer? Only the query execution, or opening the connection as well? If the first then should we initialize this closer to where it's consumed? Or if you want to timeout even if opening the connection takes a long time, then should we pass the token to connection.OpenAsync() as well?
szaboopeeter
approved these changes
Mar 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pass cancellation timeout