Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AG-10110 Add bullet chart to gallery #785

Merged
merged 1 commit into from
Dec 21, 2023
Merged

AG-10110 Add bullet chart to gallery #785

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions packages/ag-charts-website/src/constants.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,8 +88,3 @@ export const GRID_URL = SITE_URL
? 'https://grid-staging.ag-grid.com'
: 'https://ag-grid.com'
: undefined;

/**
* Skip generating the gallery images, to speed up the build process
*/
export const SKIP_GALLERY_IMAGE_GENERATION = import.meta.env?.SKIP_GALLERY_IMAGE_GENERATION;
15 changes: 15 additions & 0 deletions packages/ag-charts-website/src/content/gallery/data.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -409,6 +409,21 @@
]
}
],
[
{
"title": "Bullet Chart",
"name": "bullet-chart",
"icon": "chartsBullet",
"enterprise": true,
"examples": [
{
"title": "Simple Bullet",
"description": "",
"name": "simple-bullet"
}
]
}
],
[
{
"title": "Radar Line",
Expand Down
5 changes: 0 additions & 5 deletions packages/ag-charts-website/src/features/gallery/utils/pageData.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
import type { GalleryData } from '@ag-grid-types';
import { SKIP_GALLERY_IMAGE_GENERATION } from '@constants';

import type { ThemeName } from '../../../stores/themeStore';
import { getGeneratedContentsFileList } from '../../example-generator';
Expand Down Expand Up @@ -41,10 +40,6 @@ export function getGalleryExamplePages({ galleryData }: { galleryData: GalleryDa
}

export function getGalleryExampleThemePages({ galleryData }: { galleryData: GalleryData }) {
if (SKIP_GALLERY_IMAGE_GENERATION) {
return [];
}

const galleryExamples = getGalleryExamples({ galleryData });
const themes: ThemeName[] = [
'ag-default',
Expand Down
1 change: 0 additions & 1 deletion packages/all/.env.blt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +0,0 @@
SKIP_GALLERY_IMAGE_GENERATION=true