fixed unit test for simple service stop_announce method #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've fixed the unit test for the simple service
stop_announcemethod.This was broken in my last MR (#23) where we switched from passing a
config.Serviceto aServiceInstanceobject to theServiceAnnouncerannounce_servicemetho.` I think this fixes it.I'm not very familiar with pytest and I don't really follow why the
self.protline was needed before but it seems to fail the test now so I've removed it.I've also updated the
announce_servicetest to check the whole service instance object rather than just theservice_instance.configobject