Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/multicast eventgroups #12

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

Conversation

afflux
Copy link
Owner

@afflux afflux commented Apr 11, 2023

No description provided.

@afflux afflux force-pushed the feature/multicast-eventgroups branch from 5679954 to 93c95d6 Compare April 11, 2023 14:05
@codecov
Copy link

codecov bot commented Apr 11, 2023

Codecov Report

Merging #12 (fcc952c) into master (ab378e9) will decrease coverage by 0.87%.
The diff coverage is 84.50%.

@@            Coverage Diff             @@
##           master      #12      +/-   ##
==========================================
- Coverage   96.55%   95.69%   -0.87%     
==========================================
  Files           6        6              
  Lines        1308     1348      +40     
  Branches      210      221      +11     
==========================================
+ Hits         1263     1290      +27     
- Misses         35       46      +11     
- Partials       10       12       +2     
Files Changed Coverage Δ
src/someip/sd.py 92.16% <80.00%> (-0.80%) ⬇️
src/someip/service.py 95.93% <87.80%> (-4.07%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@afflux afflux force-pushed the feature/multicast-eventgroups branch from 93c95d6 to fcc952c Compare August 31, 2023 15:51
@werux
Copy link

werux commented May 8, 2024

Hi @afflux, is there any reason why this is still in draft mode?

I may be able to help test it and review.

@afflux
Copy link
Owner Author

afflux commented May 8, 2024

Hi @werux, I haven't yet had a chance to verify if it actually works against real implementations. Feel free to give it a go and let me know how it went.

@werux
Copy link

werux commented May 30, 2024

Hi @afflux,

I haven't had the chance to test this, but I submitted a PR to add support for SOME/IP TP (#19), can you please take a look?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants