Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support functions to facilitate use of hasql #130

Draft
wants to merge 14 commits into
base: main
Choose a base branch
from

Conversation

istathar
Copy link
Member

Handling errors properly when making database calls and ensuring telemetry is sent is surprisingly tricky. This introduces helper functions which facilitate doing these things systematically.

@istathar istathar added the improvement New feature or request label May 30, 2022
@istathar istathar self-assigned this May 30, 2022
@istathar istathar marked this pull request as draft June 3, 2022 23:19
@istathar
Copy link
Member Author

istathar commented Feb 28, 2023

I wonder if the dependency on hasql-pool is the right thing. On the one hand we've had good success using it. On the other hand resource-pool is in much better shape now. I'm trying to figure out if there's benefit to the Hasql.Pool dependency or whether using the (newly revamped) Data.Pool would be better—or whether this library should just use hasql Connection and not be involved with connection pooling at all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants