unsafeReceiveResponse that does not consume body #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Only change I'd ask you to make would be to rename the function to |
singpolyma
force-pushed
the
allow-receive-response-skip-body
branch
from
a233f32
to
3b6d7b6
Compare
This works when you know there is no body, no matter what the headers say (HEAD requests, aesiniath#114) This also works when the handler consumes whatever part of the body you actually want to use, and then you close the connection afterwards (no reusing for pipelining!) Sometimes this is a lot faster than using pipelining if you can, for example, skip a many GB download (aesiniath#113)
singpolyma
force-pushed
the
allow-receive-response-skip-body
branch
from
3b6d7b6
to
5d48210
Compare
singpolyma
changed the title
|
@afcowie changed :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This works when you know there is no body, no matter what the headers
say (HEAD requests, #114)
This also works when the handler consumes whatever part of the body you
actually want to use, and then you close the connection afterwards (no
reusing for pipelining!) Sometimes this is a lot faster than using
pipelining if you can, for example, skip a many GB download (#113)