-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add fr_fr.json and es_es.json. Configure Git to manage line endings #25
base: 1.20.1-forge
Are you sure you want to change the base?
Conversation
Yessssiiiir thank you so much! Really really appreciated. I will go ahead and pull this into all branches, What are the formatting issues you've identified? If you want to fix it that would be awesome, but only do so if you're willing! |
Git configuration: Line endingsYour git repo is not configured to handle Windows-style line endings. Some developers may use Windows OS. Without a proper configuration, this could break your code in the long run. GitHub Doc: https://docs.github.com/en/get-started/getting-started-with-git/configuring-git-to-handle-line-endings I detected the problem in the first place by using this command to find all the files in your repo containing the Windows-style line endings patterns. There was only one file concerned,
I filtered out the binary files we do not want to modify (PNG, PDN and WEBP) and adjusted the
Now, your git repo is properly configured for any developer using any OS, independently of their local git configuration. Pretty JSONI formatted all the JSON files in the
FYI, the Cheers |
Following your call on Curseforge and Modrinth, I added a translation of your mod in French and Spanish. Similar to @AsseyGithub, @avirtual777, @BesrezenUs, I only updated the default branch 1.20.1-forge.
I noticed some formatting issues in the different JSON files. If you want, I can format them all for you.