Framelabels

[mikedotalmond]

Adding Flump frame-label support for MovieSprite - #54

Also plundered some playback helpers (play,stop, get/set frame) from here:
josimard/flambe@e486575

[aduros]

There's a lot of weird reformatting in this PR :) Please try to match the project code-style and avoid cluttering the diff with lots of reformatting.

[mikedotalmond]

Ok, makes sense. I'll take a look at MovieKeyframe (and watch the formatting)

[mikedotalmond]

I made some changes in my main fork... hopefully this is towards what you wanted:
mikedotalmond@aaeb792

• moved most of the label support stuff out of MovieSprite and into MovieSymbol/MovieLayer,
• support/allow frame-labels on any movie layer
• each LayerAnimator in a MovieSprite manages a currentLabel and labelChanged property in the .composeFrame call.

[aduros]

Possible bug: Some emits are skipped if the position seeks past multiple labels in a single update (happens consistently if two labels point at the same frame)

I also wonder if a labels :Map<String,Float> on MovieSymbol wouldn't be better than the new exposed MovieLayer fields. That would simplify two common use-cases (a) getting a time position out of a label so you can seek to it (b) enumerating over all the labels. The MovieLayer array fields should be private implementation detail (seems also like they should be lifted to MovieSymbol).

[mikedotalmond]

Yeah, I had a String Map earlier but wasn't sure which approach I preferred. Happy to go back to it.

Agree about moving to MovieSymbol for most of the implementation, should help sort out the skipped label emit bug too.

[mikedotalmond]

Moved most framelabel related bits into MovieSymbol in this commit:
mikedotalmond@bde91cb

[quinnhoener]

Would love to see these features integrated into the framework, any ETA on this?

Thanks!

[mikedotalmond]

Have another look at the state of the framelabels branch - I've tidied up and reverted changes that were not directly related to framelabels support. I'm using it with flump exported animations on a flash/html5 project, and it seems stable.

[aduros]

Thanks Mike, I'll take a look at it ASAP!

[quinnhoener]

Nudge! Our animators would love you if frame labels were supported. Any updates on when this can be implemented?