Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cypress UI tests #433

Merged
merged 8 commits into from
Dec 14, 2023
Merged

Cypress UI tests #433

merged 8 commits into from
Dec 14, 2023

Conversation

andresbott
Copy link
Contributor

Migrate UI test to cypress

Description

Remove the default selenium based UI tests, and replace them with cypress

The new tests
a) follow the author flow verifying:

  • page title is editable
  • we can add a component on a page and publish that

b) verify the public page

  • check the that the front page has a hero image
  • check that search contains results

Related Issue

jira.corp.adobe.com/browse/CQ-4354669

Recordings of the verification

authoring.cy.js.mp4
publicsite.cy.js.mp4

Copy link
Member

@dulvac dulvac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool.
Minor comments

ui.tests/README.md Outdated Show resolved Hide resolved
ui.tests/README.md Outdated Show resolved Hide resolved
ui.tests/README.md Outdated Show resolved Hide resolved
ui.tests/README.md Outdated Show resolved Hide resolved
ui.tests/README.md Outdated Show resolved Hide resolved
ui.tests/Dockerfile Outdated Show resolved Hide resolved
ui.tests/Dockerfile Outdated Show resolved Hide resolved
ui.tests/pom.xml Outdated Show resolved Hide resolved
@davidjgonzalez
Copy link
Contributor

@andresbott should the PR be moved out of Draft yet?

@andresbott andresbott marked this pull request as ready for review December 14, 2023 08:58
@andresbott
Copy link
Contributor Author

@davidjgonzalez sorry, i missed the notification;
I checked again this tests on a local environment and all is green; this can be merged

@SachinMali
Copy link
Contributor

@andresbott Can you please resolve the remaining conversations, we can merge it soon then, thanks!

@andresbott
Copy link
Contributor Author

@SachinMali done; the points in the conversations were fixed; i just closed the conversations

@andresbott
Copy link
Contributor Author

@SachinMali as discussed I verified again the Local execution of all the steps to execute the UI tests against an AEMCS instance.
as well I updated the Readme accordingly

@SachinMali
Copy link
Contributor

@andresbott Thanks, appreciated calling out it's AEMCS specific.

@SachinMali SachinMali merged commit 48f414f into adobe:main Dec 14, 2023
5 checks passed
andresbott added a commit to andresbott/aem-guides-wknd that referenced this pull request Dec 18, 2023
SachinMali pushed a commit that referenced this pull request Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants