Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#431 - GraphQlIT tests are too strict #432

Merged
merged 1 commit into from
Oct 26, 2023
Merged

#431 - GraphQlIT tests are too strict #432

merged 1 commit into from
Oct 26, 2023

Conversation

gknobloch
Copy link
Member

  • Suggest not to check for strict number of results, but checking there's at least one result

Description

Adjust test to be less strict on number of results.

Related Issue

#431

Motivation and Context

Better stability of test suite, not dependent on strict number of results

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

* Suggest not to check for strict number of results, but checking there's at least one result
@davidjgonzalez davidjgonzalez merged commit 7612925 into main Oct 26, 2023
5 checks passed
@gknobloch gknobloch deleted the issue/431 branch October 26, 2023 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants