Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix replication metadata #425

Merged

Conversation

kwin
Copy link
Contributor

@kwin kwin commented Sep 15, 2023

Update filevault-package-maven-plugin to 1.3.4
Add aem-replication-metadata-validator to enforce correct replication metadata

This closes #424

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Update filevault-package-maven-plugin to 1.3.4
Add aem-replication-metadata-validator to enforce correct replication
metadata

This closes adobe#424
Copy link

@AbdullahWins AbdullahWins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well Done!

@kwin kwin marked this pull request as draft September 27, 2023 15:09
@kwin
Copy link
Contributor Author

kwin commented Sep 27, 2023

I will also add the metadata for "preview" (relevant for AEMaaCS), therefore temporarily setting the PR back to draft.

@kwin kwin marked this pull request as ready for review September 27, 2023 18:51
@SachinMali SachinMali merged commit 46392bc into adobe:main Oct 6, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect replication metadata for editable templates
3 participants