Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SITES-15239 - Update projects after Core WCM Components 2.23.2 release #415

Merged
merged 4 commits into from
Sep 4, 2023

Conversation

LSantha
Copy link
Contributor

@LSantha LSantha commented Aug 7, 2023

  • updated Core WCM Components dependency to 2.23.2
  • updated uber.jar.version to 6.5.17
  • update aem-analyse plugin to 1.5.8
  • updated AEM SDK API version to 2023.7.12874.20230726T072051Z-230702

Description

Related Issue

SITES-15239

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

 * updated Core WCM Components dependency to 2.23.2
 * updated uber.jar.version to 6.5.17
@LSantha LSantha marked this pull request as draft August 7, 2023 14:57
@davidjgonzalez davidjgonzalez marked this pull request as ready for review August 8, 2023 20:09
@davidjgonzalez davidjgonzalez marked this pull request as draft August 8, 2023 20:09
@SachinMali SachinMali requested review from davidjgonzalez and removed request for davidjgonzalez August 8, 2023 20:21
@davidjgonzalez
Copy link
Contributor

@LSantha The build is failing with

Error:  The analyser found the following errors for publish.prod : 
Error:  [api-regions] Region 'global' defined in feature 'com.adobe.aem.guides:aem-guides-wknd.all:slingosgifeature:aggregated-publish.prod:3.1.1-SNAPSHOT' declares 1 package which is not exported by any bundle:
 * com.adobe.cq.wcm.core.components.commons.editor.nextgendm

This appears to be coming from Core Components 2.32.2 .. i updated aem-analyse plugin on this branch hoping that would have new rules that support whatever this change was, but no luck. Any idea how to resolve this?

@LSantha LSantha marked this pull request as ready for review September 4, 2023 18:16
@LSantha
Copy link
Contributor Author

LSantha commented Sep 4, 2023

@davidjgonzalez , the build is passing now, probably the recent cloud release fixed it, which has the related changes for the components 2.23.2 release.

@LSantha LSantha merged commit bdd75cb into main Sep 4, 2023
5 checks passed
@LSantha LSantha deleted the SITES-15239 branch September 4, 2023 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants