Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove json index on search-hidden pages #1499

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Singularity0909
Copy link

What does this PR change? What problem does it solve?

To remove JSON index on the page set search-hidden param as true.

Was the change discussed in an issue or in the Discussions before?

No.

PR Checklist

  • This change adds/updates translations and I have used the template present here.
  • I have enabled maintainer edits for this PR.
  • I have verified that the code works as described/as intended.
  • This change adds a Social Icon which has a permissive license to use it.
  • This change does not include any CDN resources/links.
  • This change does not include any unrelated scripts such as bash and python scripts.
  • This change updates the overridden internal templates from HUGO's repository.

I'm not sure about the last check item.

Copy link

sonarcloud bot commented Apr 25, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link
Owner

@adityatelange adityatelange left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How does this affect Search? json schema has no effect on search.

For context searchHidden is to hide pages from site's search index and not for any search engine's

@Singularity0909
Copy link
Author

Singularity0909 commented Apr 28, 2024

How does this affect Search? json schema has no effect on search.

For context searchHidden is to hide pages from site's search index and not for any search engine's

@adityatelange Thanks for reviewing. In my view, currently the JSON index only works for blog searching, and it will be useless when the search function is turned off.

Sometimes I need to encrypt partial content of my blog pages.

https://github.com/Li4n0/hugo_encryptor

Through this tool, some parts of an article will be encrypted with AES and encoded into base64. However, JSON of the entire original content in the header of the webpage cannot be encrypted, which may be spied on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants