Convert to use Central Package Management #17
Conversation
lahma
force-pushed
the
cpm
branch
4 times, most recently
from
735e6b6 to
72cd3a2
Compare
* all versions in Directory.Packages.props * use net472 for executable projects * latest versions of libraries
Directory.Packages.props
Outdated
| <PackageVersion Include="System.Memory" Version="4.5.5" /> | ||
| <PackageVersion Include="System.Runtime.CompilerServices.Unsafe" Version="6.0.0" /> |
There was a problem hiding this comment.
| <PackageVersion Include="System.Memory" Version="4.5.5" /> | |
| <PackageVersion Include="System.Runtime.CompilerServices.Unsafe" Version="6.0.0" /> |
|
I have hopefully addressed review comments in the latest commit. |
|
The test failure on Windows is interesting, it seems that I get it on |
| @@ -21,7 +21,7 @@ | |||
| <!-- Configure polyfills --> | |||
|
|
|||
| <PropertyGroup> | |||
| <PolySharpIncludeGeneratedTypes Condition="'$(TargetFramework)' == 'net472'"> | |||
| <PolySharpIncludeGeneratedTypes Condition="!$([MSBuild]::IsTargetFrameworkCompatible('$(TargetFramework)', 'net6.0'))"> | |||
Directory.Packages.props
Outdated
| <PackageVersion Include="System.Memory" Version="4.5.5" /> | ||
| <PackageVersion Include="System.Runtime.CompilerServices.Unsafe" Version="6.0.0" /> |
There was a problem hiding this comment.
I still don't think we should list these two packages here (until they're needed somewhere else than the main package).
| <PackageVersion Include="System.Memory" Version="4.5.5" /> | |
| <PackageVersion Include="System.Runtime.CompilerServices.Unsafe" Version="6.0.0" /> |
Hmm, haven't been able to repro it locally so far. I suspect it's related to .NET 9. More specifically, to the windows-latest runner images having been updated to .NET 9. From the logs:
Just a wild guess but maybe .NET 9 has brought some regression in our stack space optimization. I need to do some further investigation. As for this PR, let's just ignore the failing tests for now. |
I have NET 9 SDK installed locally too.
Added explicit references to Asn1 in build.csproj. |
|
OK battling with legacy framework doesn't feel like something I can contribute the time at the moment, I'll get back to this PR when I have the energy... |
|
You've already done 99% of the work, so let's not shelve this. I made the necessary changes to push this through the finish line. I'm not sure though that CPM won't bite us in the ass in the future. Probably we should limit it to src and test projects only. Benchmarks, samples, etc. shouldn't really dictate what versions of dependencies to use in those projects. But I'm leaving it as is for now and we'll see how it works out. |
|
Thanks for the nice improvements once again! |
Directory.Packages.propsnet472for executable projects (no nasty value tuple requirements)