enhance: net bar graph show net instead of two separate bars #4033
Conversation
actual-github-bot
bot
changed the title
✅ Deploy Preview for actualbudget ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Bundle Stats — desktop-clientHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset
View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller
Unchanged
|
Bundle Stats — loot-coreHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset No files were changed View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
UnderKoen
changed the title
|
Warning There were issues while running some tools. Please review the errors and either fix the tool’s configuration or disable the tool if it’s a critical failure. 🔧 eslint
packages/desktop-client/src/components/reports/spreadsheets/calculateLegend.tsOops! Something went wrong! :( ESLint: 8.57.1 ESLint couldn't find the plugin "eslint-plugin-eslint-plugin". (The package "eslint-plugin-eslint-plugin" was not found when loaded as a Node module from the directory "/packages/eslint-plugin-actual".) It's likely that the plugin isn't installed correctly. Try reinstalling by running the following: The plugin "eslint-plugin-eslint-plugin" was referenced from the config file in "packages/eslint-plugin-actual/.eslintrc.js". If you still can't figure out the problem, please stop by https://eslint.org/chat/help to chat with the team. WalkthroughThe pull request introduces modifications to two files in the desktop client's reporting components: In Possibly related PRs
Tip CodeRabbit's docstrings feature is now available as part of our Early Access Program! Simply use the command Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
packages/desktop-client/src/components/reports/spreadsheets/calculateLegend.ts (1)
28-50: Centralize and streamline color logic
ThisgetColorfunction neatly encapsulates color-based decision-making. However, consider these refinements:
- Reduce code duplication – Lines 43 & 46 both return
theme.reportsBlue. Combine them for conciseness.- Future-proofing – If
balanceTypeOpgains more options, consider using a lookup table or mapping structure for color mapping instead of multipleifstatements.- Validation – Defensive checks on
data.totalTotalscould be helpful if there's any risk ofundefinedornullvalues.Possible minor refactor example:
function getColor(data: IntervalEntity, index: number) { if (graphType === 'DonutGraph') { return colorScale[index % colorScale.length]; } if (groupBy === 'Interval') { if (balanceTypeOp === 'totalDebts') { return theme.reportsRed; } if (balanceTypeOp === 'totalTotals') { if (data?.totalTotals < 0) { return theme.reportsRed; } return theme.reportsBlue; } - return theme.reportsBlue; } return colorScale[index % colorScale.length]; }
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
upcoming-release-notes/4033.mdis excluded by!**/*.md
📒 Files selected for processing (2)
packages/desktop-client/src/components/reports/graphs/BarGraph.tsx(0 hunks)packages/desktop-client/src/components/reports/spreadsheets/calculateLegend.ts(1 hunks)
💤 Files with no reviewable changes (1)
- packages/desktop-client/src/components/reports/graphs/BarGraph.tsx
🔇 Additional comments (3)
packages/desktop-client/src/components/reports/spreadsheets/calculateLegend.ts (3)
25-25: Maintain consistent data storage practice
Similar to the previous return statement, ensure that returning the entire GroupedEntity object as data does not introduce extra overhead or potential data leakage.
56-56: Well-defined color usage
Using the new getColor function for each legend item is a straightforward approach. This helps keep color logic in one place, making maintenance simpler.
22-22: Check for potential overexposure of data
Storing the entire IntervalEntity object as data in the legend is convenient for debugging and future expansions. However, ensure there's no sensitive or excessive data that might impact performance or expose PII.
Do you want to confirm that no sensitive fields exist on IntervalEntity objects? If so, here’s a script that attempts to find any references to possibly sensitive fields in the codebase:
✅ Verification successful
No sensitive data exposure found in IntervalEntity
Based on the search results, I can see the complete definition of IntervalEntity type in packages/loot-core/src/types/models/reports.d.ts. The type only contains financial metrics and date fields:
export type IntervalEntity = {
date?: string;
change?: number;
intervalStartDate?: string;
intervalEndDate?: string;
totalAssets: number;
totalDebts: number;
};None of these fields contain sensitive or personally identifiable information (PII). The data is purely numerical and temporal, representing financial aggregates and time intervals, which is appropriate for reporting purposes.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Searching for specific sensitive field names (like password, token, etc.) within IntervalEntity references
rg -A 5 "IntervalEntity"
Length of output: 7450
Changed the net total bar graph to:
Before:
