Fix sync errors when Simplefin account removed #4007
Conversation
✅ Deploy Preview for actualbudget ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Bundle Stats — desktop-clientHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset No files were changed View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
Bundle Stats — loot-coreHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset
View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger
Smaller No assets were smaller Unchanged No assets were unchanged |
greatwitenorth
changed the title
|
Warning There were issues while running some tools. Please review the errors and either fix the tool’s configuration or disable the tool if it’s a critical failure. 🔧 eslint
packages/loot-core/src/server/accounts/sync.tsOops! Something went wrong! :( ESLint: 8.57.1 ESLint couldn't find the plugin "eslint-plugin-eslint-plugin". (The package "eslint-plugin-eslint-plugin" was not found when loaded as a Node module from the directory "/packages/eslint-plugin-actual".) It's likely that the plugin isn't installed correctly. Try reinstalling by running the following: The plugin "eslint-plugin-eslint-plugin" was referenced from the config file in "packages/eslint-plugin-actual/.eslintrc.js". If you still can't figure out the problem, please stop by https://eslint.org/chat/help to chat with the team. WalkthroughThe pull request modifies the Possibly related PRs
Suggested labels
Suggested reviewers
Tip CodeRabbit's docstrings feature is now available as part of our Early Access Program! Simply use the command Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
packages/loot-core/src/server/accounts/sync.ts (1)
866-869: Consider adding debug logging for skipped accounts.To improve observability, consider logging when accounts are skipped due to undefined downloads.
if (!download) { + console.log(`Skipping sync for account ${account.id}: No download data available`); continue; }
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
upcoming-release-notes/4007.mdis excluded by!**/*.md
📒 Files selected for processing (1)
packages/loot-core/src/server/accounts/sync.ts(1 hunks)
🧰 Additional context used
📓 Learnings (2)
📓 Common learnings
Learnt from: matt-fidd
PR: actualbudget/actual#3581
File: packages/loot-core/src/client/actions/account.ts:180-194
Timestamp: 2024-11-10T16:45:25.627Z
Learning: In `packages/loot-core/src/client/actions/account.ts`, within the `syncAccounts` function, the batch sync request for SimpleFin accounts handles errors by returning error objects instead of throwing exceptions. Therefore, wrapping this block in a try-catch is unnecessary.
packages/loot-core/src/server/accounts/sync.ts (1)
Learnt from: matt-fidd
PR: actualbudget/actual#3581
File: packages/loot-core/src/client/actions/account.ts:180-194
Timestamp: 2024-11-10T16:45:25.627Z
Learning: In `packages/loot-core/src/client/actions/account.ts`, within the `syncAccounts` function, the batch sync request for SimpleFin accounts handles errors by returning error objects instead of throwing exceptions. Therefore, wrapping this block in a try-catch is unnecessary.
🔇 Additional comments (1)
packages/loot-core/src/server/accounts/sync.ts (1)
866-869: LGTM! Guard clause prevents processing undefined downloads.
The addition of this guard clause effectively prevents the sync process from attempting to process undefined downloads, which resolves the sync hanging issue when Simplefin accounts are removed and re-added.
|
I think this is similar to #3941? Except that one actually displays an error while your solution silently ignores it. |
|
Ok I think the two PRs might handle slightly different edge cases. But your solution does still just ignore the issue, when it probably makes sense to notify the user via UI error message that something was wrong. |
Good point! I did notice that all the errors come up at once at the very end as notifications in the bottom right. But I can see if there's a better way to handle the errors while it's checking each account. |
Recently I had to remove and then add again my bank account in the Simplefin admin due to syncing issues on their end. Once I completed this, I tried syncing my accounts before relinking them and the sync just hung, showing the message "Syncing 18 accounts remaining". The console revealed this error:
It seems like once there are orphaned accounts in my Actual database which don't exist anymore in Simplefin, that the sync fails completely.
I've added in a check to ensure that
downloadis not empty before proceeding. This seems to resolve the issue.Note, this also surfaced another issue with Simplefin where if there was a single missing account, it would return all accounts as missing. This has been reported to them and resolved.