[WIP] Fix issue where the UI is stuck sync'ing if no data from server

[psybers]

A user reported a problem where the server sent no data (it sent an empty {} object). This results in the UI being "stuck" showing it synchronizing the banks forever.

This detects the issue of an empty object and throws a BankSync exception.

It also updates the SF batch sync code to properly handle if an exception happens, by setting every account to error status. I don't know if that is what we want, but it definitely reports an error and definitely stops it from being stuck.

[netlify]

✅ Deploy Preview for actualbudget ready!

Name	Link
🔨 Latest commit	c30edc7
🔍 Latest deploy log	https://app.netlify.com/sites/actualbudget/deploys/676b806d33f4cf0008022242
😎 Deploy Preview	https://deploy-preview-3941.demo.actualbudget.org
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[psybers]

@matt-fidd Is this the logic we want? For me, this would result in 29 error messages. But in some sense that is correct, as I requested 29 accounts to sync.

[github-actions]

Bundle Stats — desktop-client

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count	Total bundle size	% Changed
10	5.64 MB	0%

Changeset

No files were changed

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset	File Size	% Changed
static/js/indexeddb-main-thread-worker-e59fee74.js	13.5 kB	0%
static/js/workbox-window.prod.es5.js	5.69 kB	0%
static/js/resize-observer.js	18.37 kB	0%
static/js/BackgroundImage.js	122.29 kB	0%
static/js/useAccountPreviewTransactions.js	1.63 kB	0%
static/js/AppliedFilters.js	10.24 kB	0%
static/js/narrow.js	83.36 kB	0%
static/js/wide.js	104.11 kB	0%
static/js/ReportRouter.js	1.58 MB	0%
static/js/index.js	3.71 MB	0%

[github-actions]

Bundle Stats — loot-core

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count	Total bundle size	% Changed
1	1.32 MB → 1.33 MB (+214 B)	+0.02%

Changeset

File	Δ	Size
packages/loot-core/src/server/main.ts	📈 +565 B (+0.80%)	68.92 kB → 69.47 kB
packages/loot-core/src/server/accounts/sync.ts	📈 +98 B (+0.37%)	26.1 kB → 26.19 kB

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

Asset	File Size	% Changed
kcab.worker.js	1.32 MB → 1.33 MB (+214 B)	+0.02%

Smaller

No assets were smaller

Unchanged

No assets were unchanged

[github-actions]

👋 Hi! It looks like this PR has not had any changes for a week now. Would you like someone to review this PR? If so - please remove the "[WIP]" prefix from the PR title. That will let the community know that this PR is open for a review.

[github-actions]

👋 Hi! It looks like this PR has not had any changes for a week now. Would you like someone to review this PR? If so - please remove the "[WIP]" prefix from the PR title. That will let the community know that this PR is open for a review.