Strip non-address characters from Forwarded for= #3343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpalmer
force-pushed
the
forwarded-strip-port
branch
from
a04f10c
to
df5d6d6
Compare
This is something of a followup to actix#2528, which asked for port information to not be included in when it was taken from the local socket. The header's element may optionally contain port information (https://datatracker.ietf.org/doc/html/rfc7239#section-6). However, as I understand it, is *supposed* to only contain an IP address, without port (per actix#2528). This PR corrects that discrepancy, making it easier to parse the result of this method in application code. There should not be any compatibility concerns, as anyone parsing the output of would already need to handle both port and portless cases anyway.
mpalmer
force-pushed
the
forwarded-strip-port
branch
from
df5d6d6
to
4d3d6f8
Compare
robjtede
approved these changes
Jun 9, 2024
|
LGTM, the prevalence (or lack thereof) of IPv6 makes this change low risk. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
Bug Fix
PR Checklist
Overview
This is something of a followup to #2528, which asked for port information to not be included in when it was taken from the local socket.
The header's element may optionally contain port information (https://datatracker.ietf.org/doc/html/rfc7239#section-6). However, as I understand it, is supposed to only contain an IP address, without port (per #2528).
This PR corrects that discrepancy, making it easier to parse the result of this method in application code.
There should not be any compatibility concerns, as anyone parsing the output of would already need to handle both port and portless cases anyway.