Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use path_for helper to include url_options in breadcrumb links #7807

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

drcapulet
Copy link

This isn't exactly the same behavior you'd get with a named path helper since it doesn't require the params key, but it is very close.

@javierjulio
Copy link
Member

What's the real objective/purpose here? I haven't had to do anything really with breadcrumb links so don't see what the need is here for.

@drcapulet
Copy link
Author

@javierjulio We need to propagate a query parameter to all links - something you can do by defining url_options in the controller to override the default.

@drcapulet drcapulet force-pushed the alexc-breadcrumb-url-options branch from 13b2e39 to 24fb389 Compare April 13, 2023 23:30
@codecov
Copy link

codecov bot commented May 11, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.03 ⚠️

Comparison is base (d0d4fa2) 98.92% compared to head (24fb389) 98.90%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7807      +/-   ##
==========================================
- Coverage   98.92%   98.90%   -0.03%     
==========================================
  Files         197      197              
  Lines        4950     4950              
==========================================
- Hits         4897     4896       -1     
- Misses         53       54       +1     
Impacted Files Coverage Δ
lib/active_admin/view_helpers/breadcrumb_helper.rb 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants